feat: Unsafe transmute for pdb symbols #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jan-auer
added a commit
that referenced
this pull request
Nov 17, 2020
* master: (22 commits) fix(debuginfo): Update dmsort to 1.0.1 to avoid panic due to UB (#287) ci: Use GHA instead of zeus (#286) ref: Introduce explicit NameMangling and better DemangleOptions (#275) meta: Bump all semver-major dependencies (#283) feat(demangle): Update swift demangler to 5.3 (#282) ref: Add File/FunctionIterator and lifetimes to DebugSession (#279) fix: Implement new clippy advice (#280) fix: Add a SymbolIterator and Lifetimes to ObjectLike trait (#277) ci: Switch to GitHub Actions (#273) ref: Introduce feature flags for demangling languages (#274) ref(common): Change InstructionInfo setters to Option (#272) ref: Remove all deprecated items (#271) ref: Replace failure with std::error::Error (#264) ref: Remove deprecated proguard support (#267) build: Reorganize the workspace (#266) build(unreal): Rename with-serde to serde (#265) fix(debuginfo): Detect mangled anonymous namespaces in PDB inlinees (#261) release: 7.5.0 meta: Update changelog for 7.5.0 feat: Unsafe transmute for PDB symbols (#258) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works around compilation errors on nightly when casting to the generic
DynIteratortype. This is caused by invariant lifetimes on PDB's stream type. The transmute is actually safe since the lifetime of the data is proved to be larger than the lifetime of the derived object. However, we can avoid the transmute in the future by changing theObjectLiketrait to correct lifetimes, which will constitute a breaking change.