Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref: Replace failure with std::error::Error #264

Merged
merged 15 commits into from
Sep 24, 2020
Merged

ref: Replace failure with std::error::Error #264

merged 15 commits into from
Sep 24, 2020

Conversation

jan-auer
Copy link
Member

@jan-auer jan-auer commented Sep 17, 2020 •
edited
Loading

Ref #259

@jan-auer jan-auer requested a review from a team September 17, 2020 11:00
flub
flub previously approved these changes Sep 17, 2020
View reviewed changes
@jan-auer jan-auer marked this pull request as draft September 17, 2020 13:10
@Swatinem Swatinem requested a review from flub September 18, 2020 13:12
@jan-auer jan-auer marked this pull request as ready for review September 18, 2020 14:30
@jan-auer
Copy link
Member Author

This is essentially ready for review, thanks a bunch to @Swatinem for wrapping this up.

I'll also do another pass through all changes, so please don't merge just yet.

jan-auer
jan-auer commented Sep 18, 2020
View reviewed changes
symbolic-cabi/src/core.rs Outdated Show resolved Hide resolved
symbolic-cabi/src/core.rs Outdated Show resolved Hide resolved
symbolic-debuginfo/src/elf.rs Outdated Show resolved Hide resolved
symbolic-debuginfo/src/object.rs Show resolved Hide resolved
symbolic-debuginfo/src/pdb.rs Outdated Show resolved Hide resolved
symbolic-debuginfo/src/sourcebundle.rs Outdated Show resolved Hide resolved
@jan-auer jan-auer dismissed flub’s stale review September 21, 2020 15:00

This PR needs more updates.

jan-auer
jan-auer commented Sep 24, 2020
View reviewed changes
Copy link
Member Author

@jan-auer jan-auer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, let's ship this.

@Swatinem Swatinem merged commit d3873d6 into master Sep 24, 2020
@Swatinem Swatinem deleted the ref/remove-failure branch September 24, 2020 07:39
jan-auer added a commit that referenced this pull request Nov 17, 2020
@jan-auer
Merge branch 'master' into feature/wasm
bc6b8e5 
* master: (22 commits)
  fix(debuginfo): Update dmsort to 1.0.1 to avoid panic due to UB (#287)
  ci: Use GHA instead of zeus (#286)
  ref: Introduce explicit NameMangling and better DemangleOptions (#275)
  meta: Bump all semver-major dependencies (#283)
  feat(demangle): Update swift demangler to 5.3 (#282)
  ref: Add File/FunctionIterator and lifetimes to DebugSession (#279)
  fix: Implement new clippy advice (#280)
  fix: Add a SymbolIterator and Lifetimes to ObjectLike trait (#277)
  ci: Switch to GitHub Actions (#273)
  ref: Introduce feature flags for demangling languages (#274)
  ref(common): Change InstructionInfo setters to Option (#272)
  ref: Remove all deprecated items (#271)
  ref: Replace failure with std::error::Error (#264)
  ref: Remove deprecated proguard support (#267)
  build: Reorganize the workspace (#266)
  build(unreal): Rename with-serde to serde (#265)
  fix(debuginfo): Detect mangled anonymous namespaces in PDB inlinees (#261)
  release: 7.5.0
  meta: Update changelog for 7.5.0
  feat: Unsafe transmute for PDB symbols (#258)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Swatinem Swatinem Swatinem approved these changes

@flub flub Awaiting requested review from flub

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jan-auer @flub @Swatinem