ref: Add File/FunctionIterator and lifetimes to DebugSession #279
Conversation
Swatinem
changed the title
Swatinem
force-pushed
the
fix/session-lifetimes-2
branch
from
a708002
to
7f48c11
Compare
| @@ -602,21 +602,27 @@ pub type DynIterator<'a, T> = Box<dyn Iterator<Item = T> + 'a>; | |||
| /// - Read headers of compilation units (compilands) to resolve cross-unit references. | |||
| /// | |||
| /// [`ObjectLike::debug_session`]: trait.ObjectLike.html#tymethod.debug_session | |||
| pub trait DebugSession { | |||
| pub trait DebugSession<'session> { | |||
There was a problem hiding this comment.
Usually, we don't need the 'data lifetime here, but do we need the 'object one?
There was a problem hiding this comment.
On taking a second look, I think we can get away without, since we can still bind it in the associated types on the concrete implementation. In that case, 'object: 'session would need to be fulfilled.
There was a problem hiding this comment.
Yes, I think that should be enough.
There was a problem hiding this comment.
What if we do the same for the ObjectLike trait, to only have the 'object lifetime there?
There was a problem hiding this comment.
To return references tied to the objects lifetime?
There was a problem hiding this comment.
Correct. This would give us the benefit of not having to clone in PdbObject::symbols, and I think that use cases where you need the 'data life time but cannot hold the objects are very scarce in hindsight.
* master: fix: Implement new clippy advice (#280)
| type FunctionIterator = BreakpadFunctionIterator<'session>; | ||
| type FileIterator = BreakpadFileIterator<'session>; |
There was a problem hiding this comment.
Just as a thought experiment. You can make these two 'data, I think. You may need 'data: 'session for this, but then you're most faithful to the lifetime. The downside of that approach would be that if you need to constrain the lifetime in future, you need to "break" the trait implementation.
There was a problem hiding this comment.
I tried in an earlier experiment. Apparently one or two of the concrete implementations returns data tied to the session. Maybe we can revisit at a later point.
* master: (22 commits) fix(debuginfo): Update dmsort to 1.0.1 to avoid panic due to UB (#287) ci: Use GHA instead of zeus (#286) ref: Introduce explicit NameMangling and better DemangleOptions (#275) meta: Bump all semver-major dependencies (#283) feat(demangle): Update swift demangler to 5.3 (#282) ref: Add File/FunctionIterator and lifetimes to DebugSession (#279) fix: Implement new clippy advice (#280) fix: Add a SymbolIterator and Lifetimes to ObjectLike trait (#277) ci: Switch to GitHub Actions (#273) ref: Introduce feature flags for demangling languages (#274) ref(common): Change InstructionInfo setters to Option (#272) ref: Remove all deprecated items (#271) ref: Replace failure with std::error::Error (#264) ref: Remove deprecated proguard support (#267) build: Reorganize the workspace (#266) build(unreal): Rename with-serde to serde (#265) fix(debuginfo): Detect mangled anonymous namespaces in PDB inlinees (#261) release: 7.5.0 meta: Update changelog for 7.5.0 feat: Unsafe transmute for PDB symbols (#258) ...
continuation of #277