ref: Move FunctionStack into its own module #627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamilogorek
approved these changes
Jul 22, 2022
Codecov Report
@@ Coverage Diff @@
## master #627 +/- ##
=======================================
Coverage 70.83% 70.83%
=======================================
Files 96 96
Lines 18119 18120 +1
=======================================
+ Hits 12834 12836 +2
+ Misses 5285 5284 -1 |
mstange
reviewed
Jul 23, 2022
| @@ -670,6 +671,7 @@ impl<'s> Unit<'s> { | |||
| line: line_info.line_start.into(), | |||
| }); | |||
| } | |||
| lines.sort_by_key(|line| line.address); | |||
There was a problem hiding this comment.
Ah, perfect, I was thinking about submitting a similar patch (also with the first() / last() change below). Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.