Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: PE embedded PPDB decompression to a custom writer #757

Merged
merged 3 commits into from
Feb 7, 2023
Merged

feat: PE embedded PPDB decompression to a custom writer #757

merged 3 commits into from
Feb 7, 2023

Conversation

vaind
Copy link
Collaborator

@vaind vaind commented Feb 7, 2023

Part of #750

@github-actions
Copy link

github-actions bot commented Feb 7, 2023 •
edited
Loading

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 737376b

This was referenced Feb 7, 2023
Merged
Closed
@codecov
Copy link

codecov bot commented Feb 7, 2023 •
edited
Loading

Codecov Report

Merging #757 (737376b) into master (2fe64b8) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #757      +/-   ##
==========================================
+ Coverage   73.88%   73.89%   +0.01%     
==========================================
  Files          69       69              
  Lines       14951    14949       -2     
==========================================
+ Hits        11046    11047       +1     
+ Misses       3905     3902       -3

@vaind vaind marked this pull request as ready for review February 7, 2023 13:10
@vaind vaind requested a review from a team February 7, 2023 13:10
Swatinem
Swatinem approved these changes Feb 7, 2023
View reviewed changes
Copy link
Member

@Swatinem Swatinem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say its up to you if you want to keep the convenience methods.

Usually its the callers responsibility what kind of Write they want to provide, if they want to use a BufWriter at all, etc.

symbolic-debuginfo/src/pe.rs Outdated Show resolved Hide resolved
@vaind vaind changed the title feat: PE - decompress embedded PPDB to file feat: refactor PE embedded PPDB decompression Feb 7, 2023
@vaind vaind changed the title feat: refactor PE embedded PPDB decompression feat: PE embedded PPDB decompression to a custom writer Feb 7, 2023
@vaind vaind enabled auto-merge (squash) February 7, 2023 14:07
@vaind vaind merged commit 4fc02aa into master Feb 7, 2023
@vaind vaind deleted the feat/pe-decompress-to-file branch February 7, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Swatinem Swatinem Swatinem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vaind @Swatinem