enhance: make mapping by params initialization optional (android deobfuscation) #823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #823 +/- ##
=======================================
Coverage 74.81% 74.82%
=======================================
Files 63 63
Lines 15678 15685 +7
=======================================
+ Hits 11730 11736 +6
- Misses 3948 3949 +1 |
Swatinem
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follow the changes in getsentry/rust-proguard#34
This will allow us to make
mappings_by_paramsinitialization optional so that we don't incur in unnecessary memory increase in those part of sentry services where deobfuscation based on parameters list instead of line numbers is not necessary.