Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid infinite recursion on indirect self-references #836

Merged

Conversation

benjaminRomano
Copy link
Contributor

Background

If there is an indirect self-reference, infinite recursion can occur.

Changes

  • keep track if the prior entry is the same as the next entry to go to and skip function name resolution

Test Plan

  • tested against a symbol file where this was occurring and it no longer crashes

symbolic-debuginfo/src/dwarf.rs Outdated Show resolved Hide resolved
Co-authored-by: Sebastian Zivota <loewenheim@users.noreply.github.com>
Copy link

codecov bot commented May 2, 2024

Codecov Report

Attention: Patch coverage is 92.30769% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 77.51%. Comparing base (bd90dfb) to head (7a7be36).
Report is 1 commits behind head on master.

❗ Current head 7a7be36 differs from pull request most recent head e987585. Consider uploading reports for the commit e987585 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #836      +/-   ##
==========================================
+ Coverage   74.45%   77.51%   +3.06%     
==========================================
  Files          63       61       -2     
  Lines       15432    14838     -594     
==========================================
+ Hits        11490    11502      +12     
+ Misses       3942     3336     -606     

@loewenheim
Copy link
Contributor

Nice work, would you mind adding a changelog entry?

@benjaminRomano
Copy link
Contributor Author

done

@loewenheim loewenheim merged commit e532563 into getsentry:master May 7, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants