feat: source context links support #1103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1103 +/- ##
==========================================
- Coverage 74.14% 70.95% -3.19%
==========================================
Files 86 86
Lines 12476 12517 +41
==========================================
- Hits 9250 8882 -368
- Misses 3226 3635 +409 |
vaind
force-pushed
the
feat/source-links
branch
from
edc4ea3
to
28f50c5
Compare
vaind
force-pushed
the
feat/source-links
branch
from
28f50c5
to
8f94914
Compare
Swatinem
reviewed
Mar 17, 2023
vaind
force-pushed
the
feat/source-links
branch
from
e6815e3
to
260b295
Compare
This was referenced Mar 18, 2023
Swatinem
approved these changes
Mar 20, 2023
Co-authored-by: Arpad Borsos <swatinem@swatinem.de>
Swatinem
reviewed
Mar 20, 2023
Comment on lines
+157
to
+158
| // Only resolve source context from URLs if the frame is "in-app". | ||
| if frame.raw.in_app.unwrap_or(false) { |
There was a problem hiding this comment.
This also needs changes in the sentry processor to enable this, as it current does not send any in_app attributes.
The other problems with this that come to mind:
in_appis being modified/set by grouping, which runs after symbolication.- minidumps never set
in_appat all. neither do some SDKs like Native. However those debug files do not (yet?) have support for source links.
I’m okay with merging this as is, but this might need to be revisited.
There was a problem hiding this comment.
in .NET, in_app is being sent from the SDK. What would need to change for that to get propagated here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of getsentry/symbolic#735