Tighten up download related timeouts #1190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1190 +/- ##
==========================================
- Coverage 75.59% 75.27% -0.33%
==========================================
Files 87 87
Lines 13839 13823 -16
==========================================
- Hits 10462 10405 -57
- Misses 3377 3418 +41 |
beezz
approved these changes
May 15, 2023
Introduces a new `DownloadTimeouts` struct to group all the download-related timeouts. Introduces a new distinction between connect/HEAD timeout, and feeds the connect timeout and the global download timeout directly to reqwest.
Swatinem
force-pushed
the
tighter-timeouts
branch
from
20a87c1
to
a85d807
Compare
loewenheim
reviewed
May 15, 2023
loewenheim
approved these changes
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a new
DownloadTimeoutsstruct to group all the download-related timeouts. Introduces a new distinction between connect/HEAD timeout, and feeds the connect timeout and the global download timeout directly to reqwest.