Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add back version to symsorter CLI #1219

Merged
merged 4 commits into from
Jun 16, 2023

Conversation

supervacuus
Copy link
Collaborator

The latest release from today (23.6.0) introduced a regression to the symsorter CLI: the option/flag --version no longer works and isn't mentioned anymore in the help output.

This regression was introduced by the dependency switch from structopt to clap (#1209). structopt adds the version flag automagically as the CARGO_PKG_VERSION if not set (nor explicitly disabled via no_version): https://docs.rs/structopt/latest/structopt/#magical-methods

Of course, clap does the opposite and requires version to be enabled via the command attribute: https://docs.rs/clap/latest/clap/_derive/index.html#command-attributes

This should probably be fixed in the other CLIs as well (besides symbolicator itself since it is explicitly overwritten there), let me know.

@codecov
Copy link

codecov bot commented Jun 15, 2023

Codecov Report

Merging #1219 (9c05d45) into master (a06fe63) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1219      +/-   ##
==========================================
- Coverage   75.41%   75.40%   -0.01%     
==========================================
  Files          87       87              
  Lines       13856    13856              
==========================================
- Hits        10449    10448       -1     
- Misses       3407     3408       +1     

@Swatinem Swatinem enabled auto-merge (squash) June 16, 2023 08:09
@Swatinem Swatinem merged commit 0186ff4 into master Jun 16, 2023
@Swatinem Swatinem deleted the fix/add_back_version_to_symsorter branch June 16, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants