fix: add back version to symsorter CLI #1219
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest release from today (
23.6.0
) introduced a regression to thesymsorter
CLI: the option/flag--version
no longer works and isn't mentioned anymore in thehelp
output.This regression was introduced by the dependency switch from
structopt
toclap
(#1209).structopt
adds theversion
flag automagically as theCARGO_PKG_VERSION
if not set (nor explicitly disabled viano_version
): https://docs.rs/structopt/latest/structopt/#magical-methodsOf course,
clap
does the opposite and requiresversion
to be enabled via the command attribute: https://docs.rs/clap/latest/clap/_derive/index.html#command-attributesThis should probably be fixed in the other CLIs as well (besides
symbolicator
itself since it is explicitly overwritten there), let me know.