Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Track Sessions for each request #289

Merged
merged 2 commits into from
Dec 18, 2020
Merged

feat: Track Sessions for each request #289

merged 2 commits into from
Dec 18, 2020

Conversation

Swatinem
Copy link
Member

@Swatinem Swatinem commented Nov 11, 2020

This will create a new sentry session for each symbolication task, and flag that as abnormal in case it hits a timeout. Otherwise sessions will be closed when the hub/future they were created on is dropped.

@Swatinem Swatinem requested a review from a team November 11, 2020 15:01
@Swatinem Swatinem marked this pull request as ready for review November 12, 2020 14:32
src/actors/symbolication.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@flub flub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not really sure what changed since last review? It still would seem more normal to me if the session was explicitly terminated in the same place for all cases taking care of ensuring the session is errored when needed.

Copy link
Member

@jan-auer jan-auer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In symbolicator, we have to tweak the meaning of our session statuses:

  • "crashed" can be seen as fatal errors, where we're not able to deliver a symbolication result due to a severe issue. This is if we fail I/O locally, if the task times out, or if the task is killed.
  • "errored" should be around problems with the payload and potentially also when required symbols fail to compute.
  • Everything else can be OK.

@flub
Copy link
Contributor

flub commented Dec 9, 2020

In symbolicator, we have to tweak the meaning of our session statuses:

  • "crashed" can be seen as fatal errors, where we're not able to deliver a symbolication result due to a severe issue. This is if we fail I/O locally, if the task times out, or if the task is killed.
  • "errored" should be around problems with the payload and potentially also when required symbols fail to compute.
  • Everything else can be OK.

So does this PR implement this currently?

@Swatinem
Copy link
Member Author

So does this PR implement this currently?

It should, yes. Things are marked as crashed on those conditions, otherwise the errored flag depends on ingesting error events during a sessions lifetime, so that should be the case as well.

Copy link
Contributor

@flub flub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies, I need a bigger redder flag on my screen saying i have unfinished reviews. LGTM!

@Swatinem Swatinem merged commit 12009fd into master Dec 18, 2020
@Swatinem Swatinem deleted the feat/sessions branch December 18, 2020 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants