Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Report unused missing unwind info as unused #293

Merged
merged 3 commits into from
Nov 17, 2020

Conversation

jan-auer
Copy link
Member

We report unwind information as missing, even if it is not required for stack walking on platforms or builds where a frame pointer is available. Since this is not an error and the user should not be alerted to this, we should report as unused, instead.

@jan-auer jan-auer requested a review from a team November 17, 2020 09:46
@jan-auer jan-auer self-assigned this Nov 17, 2020
src/actors/symbolication.rs Outdated Show resolved Hide resolved
@jan-auer jan-auer requested a review from flub November 17, 2020 13:40
@jan-auer jan-auer merged commit 5fd8b3d into master Nov 17, 2020
@jan-auer jan-auer deleted the fix/unwind-status-unused branch November 17, 2020 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants