Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Update symbolic #457

Merged
merged 2 commits into from
Jun 8, 2021
Merged

ref: Update symbolic #457

merged 2 commits into from
Jun 8, 2021

Conversation

Swatinem
Copy link
Member

@Swatinem Swatinem commented Jun 7, 2021

This updates includes bumps to a few dependencies (goblin, gimli, wasm stuff),
as well as specific fixes to extract or hand-roll CFI for apple system symbols.

#skip-changelog

This updates includes bumps to a few dependencies (goblin, gimli, wasm stuff),
as well as specific fixes to extract or hand-roll CFI for apple system symbols.
@Swatinem Swatinem requested a review from a team June 7, 2021 15:50
@flub
Copy link
Contributor

flub commented Jun 8, 2021

I'm actually wondering if we should be skipping changelog for most of these bumps. Like, symbolic is a core part of symbolicator. Does it make sense to summarise why we are bumping? E.g. what feature we wanted? Maybe even with a pointer to the changelog of the dep?

@Swatinem Swatinem merged commit e68be17 into master Jun 8, 2021
@Swatinem Swatinem deleted the ref/update-symbolic branch June 8, 2021 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants