-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Read thread names from minidumps and Apple crash reports #834
Conversation
Instructions for snapshot changesSentry runs a symbolicator integration test suite located at Follow these steps to update snapshots in Sentry:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 lets add an integration test as a followup once we actually have a minidump with thread names in it ;-)
Codecov Report
@@ Coverage Diff @@
## master #834 +/- ##
==========================================
+ Coverage 75.08% 75.13% +0.04%
==========================================
Files 49 50 +1
Lines 10862 11095 +233
==========================================
+ Hits 8156 8336 +180
- Misses 2706 2759 +53
Continue to review full report at Codecov.
|
fixes #833