-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Properly mask Portable PDB Age for symstore/SSQP lookups #888
Conversation
Portable PDB lookups via the SSQP scheme say that the `Age` portion of the ID needs to be replaced with u32::MAX. See https://github.com/dotnet/symstore/blob/main/docs/specs/SSQP_Key_Conventions.md#portable-pdb-signature This allows us to properly look up Portable PDB files on the upstream microsoft symbol server.
Instructions for snapshot changesSentry runs a symbolicator integration test suite located at Follow these steps to update snapshots in Sentry:
|
@@ -38,7 +38,7 @@ sources: | |||
type: http | |||
url: https://msdl.microsoft.com/download/symbols/ | |||
layout: { type: "symstore" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tbh, I have no idea why this is symstore
and not ssqp
. The only difference seems to be the casing, and the upstream microsoft server seems to be case insensitive anyway as far as I have tried.
Codecov ReportBase: 70.27% // Head: 70.28% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #888 +/- ##
=======================================
Coverage 70.27% 70.28%
=======================================
Files 59 59
Lines 11493 11496 +3
=======================================
+ Hits 8077 8080 +3
Misses 3416 3416
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Portable PDB lookups via the SSQP scheme say that the
Age
portion of the ID needs to be replaced with u32::MAX.See https://github.com/dotnet/symstore/blob/main/docs/specs/SSQP_Key_Conventions.md#portable-pdb-signature
This allows us to properly look up Portable PDB files on the upstream microsoft symbol server.
For example, http://msdl.microsoft.com/download/symbols/microsoft.aspnetcore.routing.pdb/fbd5dfdfa5a44e09a75862fcbb8c914aFFFFFFFF/microsoft.aspnetcore.routing.pdb might be such a valid file which matches a stack frame from https://sentry.io/organizations/sentry-sdks/issues/2442781715/events/a4f4c59a7d1a4b06bd98c0d1dcfa7e8c/?project=5428537