Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Remove unused processing_pool_size config #910

Merged
merged 2 commits into from
Nov 8, 2022
Merged

Conversation

Swatinem
Copy link
Member

@Swatinem Swatinem commented Nov 8, 2022

The config was previously used to control the number of procspawn subprocesses. It is being completely unused since procspawn usage was removed.

The config was previously used to control the number of procspawn subprocesses. It is being completely unused since procspawn usage was removed.
@Swatinem Swatinem requested a review from a team November 8, 2022 09:16
@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2022

Codecov Report

Base: 69.04% // Head: 69.04% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (1e6ffaa) compared to base (d7a7725).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #910      +/-   ##
==========================================
- Coverage   69.04%   69.04%   -0.01%     
==========================================
  Files          66       66              
  Lines       11481    11480       -1     
==========================================
- Hits         7927     7926       -1     
  Misses       3554     3554              
Impacted Files Coverage Δ
crates/symbolicator-service/src/config.rs 83.39% <ø> (-0.06%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Swatinem Swatinem enabled auto-merge (squash) November 8, 2022 10:08
@Swatinem Swatinem merged commit 173435f into master Nov 8, 2022
@Swatinem Swatinem deleted the ref/rm-poolsize branch November 8, 2022 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants