Add a check to see if a lock is from a closed PR #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lynnagara
reviewed
Aug 13, 2024
lynnagara
reviewed
Aug 13, 2024
lynnagara
reviewed
Aug 13, 2024
lynnagara
force-pushed
the
fix/unlock-bug
branch
from
841b2eb
to
c4ffe5e
Compare
lynnagara
reviewed
Aug 14, 2024
maxwelllwang
suggested changes
Aug 14, 2024
bukzor
approved these changes
Aug 14, 2024
Co-authored-by: Buck Evan <buck.evan@sentry.io>
Co-authored-by: Buck Evan <buck.evan@sentry.io>
maxwelllwang
approved these changes
Aug 14, 2024
lynnagara
approved these changes
Aug 14, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlocks the slice during the plan stage if the lock is found to be on a closed PR.
This isn't fully resilient.
If PR 1 is still open but no longer touching a file, PR 2 will still be unable to unlock. PR 1 has to be closed/merged.