Migrate to scala-js-dom #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AugustNagro
reviewed
Jul 22, 2021
| componentBuilder: ComponentBuilder, | ||
| element: Element = js.Dynamic.global.document.body.asInstanceOf[Element] | ||
| ): Unit = | ||
| componentBuilder(using element, RootBinding()) |
There was a problem hiding this comment.
Can you un-delete this file?
There was a problem hiding this comment.
Restored helpers file
|
Thanks for this MR, was very helpful. v0.4.0 adds the new scala-js-dom release. I'm updating the website with all the changes now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE
until scala-js-dom 2.0.0 is published (when @sjrd returns from vacation) one would have to
+publishLocalscala-js-dom repo in order for this PR to build. Assume the release will happen quite soon since there's demand for a Scala 3 supported release of scala-js-dom.