-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added PHG Campaign Token support. #6
Added PHG Campaign Token support. #6
Conversation
@@ -96,6 +97,10 @@ - (void)performApiCallForMethod:(NSString*)method | |||
if (self.affiliateToken && self.affiliateToken.length > 0) | |||
newParams[@"at"] = self.affiliateToken; | |||
|
|||
// Add campaign token if supplied | |||
if (self.campaignToken && self.campaignToken.length > 0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you mind using curly braces in this if statement? Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could absolutely do that, but don't you want me to follow the code style? See the lines just before... Just checking :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see now that curly braces was probably supposed to be used there to. I'' make a new commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. Would you mind adding braces to that if statement too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep.
Added PHG Campaign Token support.
Thanks for the PR :) |
Thank you! 2015-05-12 11:50 GMT+02:00 Piers notifications@github.com:
|
Just a heads up, your commit is included in v1.0.0 which is available via cocoapods. |
I was hoping for that :) Thanks! 2015-05-12 12:06 GMT+02:00 Piers notifications@github.com:
|
No description provided.