Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added PHG Campaign Token support. #6

Merged
merged 2 commits into from
May 12, 2015

Conversation

claesjacobsson
Copy link
Contributor

No description provided.

@@ -96,6 +97,10 @@ - (void)performApiCallForMethod:(NSString*)method
if (self.affiliateToken && self.affiliateToken.length > 0)
newParams[@"at"] = self.affiliateToken;

// Add campaign token if supplied
if (self.campaignToken && self.campaignToken.length > 0)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind using curly braces in this if statement? Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could absolutely do that, but don't you want me to follow the code style? See the lines just before... Just checking :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see now that curly braces was probably supposed to be used there to. I'' make a new commit.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Would you mind adding braces to that if statement too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep.

eightytwo pushed a commit that referenced this pull request May 12, 2015
@eightytwo eightytwo merged commit 830a3bf into getsling:master May 12, 2015
@eightytwo
Copy link
Contributor

Thanks for the PR :)

@claesjacobsson
Copy link
Contributor Author

Thank you!

2015-05-12 11:50 GMT+02:00 Piers notifications@github.com:

Thanks for the PR :)


Reply to this email directly or view it on GitHub
#6 (comment).

@claesjacobsson claesjacobsson deleted the campaign-token-support branch May 12, 2015 10:00
@eightytwo
Copy link
Contributor

Just a heads up, your commit is included in v1.0.0 which is available via cocoapods.

@claesjacobsson
Copy link
Contributor Author

I was hoping for that :) Thanks!

2015-05-12 12:06 GMT+02:00 Piers notifications@github.com:

Just a heads up, your commit is included in v1.0.0 which is available via
cocoapods.


Reply to this email directly or view it on GitHub
#6 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants