Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple arguments to %cargo_install #90

Merged
merged 1 commit into from
Sep 15, 2024

Conversation

Staudey
Copy link
Member

@Staudey Staudey commented Jul 15, 2024

This allows multiple arguments to the %cargo_install macro, in case there are several binaries to install

Resolves getsolus/packages#3230

Copy link
Contributor

@ermo ermo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: If you did, say, $binary or $executable instead instead of $i, it'd be self-documenting... =)

LGTM, thanks!

Signed-off-by: Thomas Staudinger <Staudi.Kaos@gmail.com>
@Staudey
Copy link
Member Author

Staudey commented Jul 15, 2024

Alan Turing told me to do it like that

Copy link
Contributor

@ermo ermo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@androidnisse
Copy link

Can this be pushed now so the last cargo macros can be fixed? :)

@joebonrichie joebonrichie merged commit c7074c2 into getsolus:master Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

new macros for cargo does not accept more then one binary
4 participants