Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updatekeys: Make file path absolute #682

Merged
merged 1 commit into from
Jun 17, 2020
Merged

updatekeys: Make file path absolute #682

merged 1 commit into from
Jun 17, 2020

Conversation

mhyllander
Copy link
Contributor

"sops updatekeys" is not working the same as when encrypting a file. The
reason is that for "sops --encrypt", the file path is made absolute before
it is compared with the path_regex in the config file. This is not done for
"sops updatekeys", therefore it does not match the correct entry in the
config file when updating keys.

"sops updatekeys" is not working the same as when encrypting a file. The
reason is that for "sops --encrypt", the file path is made absolute before
it is compared with the path_regex in the config file. This is not done for
"sops updatekeys", therefore it does not match the correct entry in the
config file when updating keys.
@codecov-commenter
Copy link

Codecov Report

Merging #682 into develop will increase coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #682      +/-   ##
===========================================
+ Coverage    38.08%   38.23%   +0.15%     
===========================================
  Files           23       23              
  Lines         3329     3329              
===========================================
+ Hits          1268     1273       +5     
+ Misses        1931     1927       -4     
+ Partials       130      129       -1     
Impacted Files Coverage Δ
stores/flatten.go 91.52% <0.00%> (+4.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94b5021...63b22a2. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants