-
Notifications
You must be signed in to change notification settings - Fork 877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add filename to exec-file #761
Conversation
df51e2f
to
1a810e1
Compare
Before we add a new feature that we'll have to maintain forever, can you explain why this is useful for you? The file name gets passed to the command anyway, and there's no way for the command to know what it'll be ahead of time because the directory will have a random name. |
@autrilla I have updated the description. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm OK with adding the feature, but other than my code comment, can you please:
- Document this in README.md (similar to how e.g.
--user
is documented). - Modify the description with a more concrete example of a tool (actual commands, terraform works for me) that needs this to work properly? It would be useful for other people searching for a solution when they encounter the same problem you did.
1a810e1
to
513f793
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! We have some CI issues, but I'll make sure this PR will make it into the next release.
Looking forward to use this feature 😄 |
Can you please rebase so this branch picks up the CI fixed that are now in develop? |
513f793
to
4a5ceca
Compare
@autrilla done |
Thanks! |
Some tools (e.g. Terraform) require the right file extension to recognize the file type.
see more details for terraform at https://www.terraform.io/docs/configuration/variables.html#variable-definitions-tfvars-files
i get this error
works for me: