Skip to content

v9.9.3-beta.3

v9.9.3-beta.3: fix: ctx menu failure and imperative closure edge cases (#3844)
@isekovanic isekovanic tagged this 07 Oct 11:27 
## 🎯 Goal

Linear ticket:
https://linear.app/stream/issue/RN-442/request-failures-and-closure-edge-cases-in-ctx-menu

This PR resolves 2 UI issues with the contextual menu:

1. Errors on actions get all subsequent actions stuck (this happens
because errors will not clear the action queue and the pending action
will remain first, so if it continues failing (i.e improper permissions
or something) it will block all actions following it from running as it
will simply throw mid for cycle.
2. The hardware back button (or back gesture) on Android keep the
context menu open and since it overlays all of the screens it
essentially keeps the opaque background while not actually closing the
overlay.

## 🛠 Implementation details

<!-- Provide a description of the implementation -->

## 🎨 UI Changes

<!-- Add relevant screenshots -->

<details>
<summary>iOS</summary>


<table>
    <thead>
        <tr>
            <td>Before</td>
            <td>After</td>
        </tr>
    </thead>
    <tbody>
        <tr>
            <td>
                <!--<img src="" /> -->
            </td>
            <td>
                <!--<img src="" /> -->
            </td>
        </tr>
    </tbody>
</table>
</details>


<details>
<summary>Android</summary>

<table>
    <thead>
        <tr>
            <td>Before</td>
            <td>After</td>
        </tr>
    </thead>
    <tbody>
        <tr>
            <td>
                <!--<img src="" /> -->
            </td>
            <td>
                <!--<img src="" /> -->
            </td>
        </tr>
    </tbody>
</table>
</details>

## 🧪 Testing

<!-- Explain how this change can be tested (or why it can't be tested)
-->

## ☑️ Checklist

- [ ] I have signed the [Stream
CLA](https://docs.google.com/forms/d/e/1FAIpQLScFKsKkAJI7mhCr7K9rEIOpqIDThrWxuvxnwUq2XkHyG154vQ/viewform)
(required)
- [ ] PR targets the `develop` branch
- [ ] Documentation is updated
- [ ] New code is tested in main example apps, including all possible
scenarios
  - [ ] SampleApp iOS and Android
  - [ ] Expo iOS and Android
Assets 2
Loading