-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extra tags after tag renaming #1058
Comments
Hmm, I wonder if this might be an explanation for the long-standing super annoying tags duplication issue, #605 ? It would be awesome if you could try fixing both your issue and that one (if they are not exactly the same) simultaneously :) |
I think the unwanted tags appear for different reasons in the two cases. Here, we have a faulty renaming. In #605, the tag parsing kicks in too early. (There, we could consider preventing the processing of the current word when parsing the tags.) Nevertheless, I can take a look at both of them. :) |
Does this also get fixed by your PR #1062, or that one was only meant for 605? |
No, this is still a work in progress. PR 1062 was only for 605. |
Since a tag name can be a prefix of another tag or part of an email address, a simple str.replace() call would lead to unexpected behaviour. This fixes GitHub issue getting-things-gnome#1058
Since a tag name can be a prefix of another tag or part of an email address, a simple str.replace() call would lead to unexpected behaviour. This fixes GitHub issue #1058
Renaming a tag that is a prefix of another tag adds unwanted tags to other tasks.
Steps to reproduce:
@apple
tag.@applepie
tag.@apple
tag using the sidebar's "Edit..." feature to@orange
.@orangepie
tag.The main cause is possibly that the corresponding method uses a simple search-and-replace for tag renaming. (The code should ensure that it replaces only whole tag names.)
The text was updated successfully, but these errors were encountered: