Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tr.json #1887

Merged

Conversation

JIPrettyCool
Copy link

@JIPrettyCool JIPrettyCool commented Aug 1, 2024

changed "İyi öğleden sonra" to "Tünaydın" which less funnier and proper way to say good afternoon.

@nmfretz
Copy link
Collaborator

nmfretz commented Aug 4, 2024

Thanks for going through the Turkish translation @JIPrettyCool! Really appreciate it. Are there any other funny/weird translations that we should change?

@mikropsoft
Copy link

Thanks for going through the Turkish translation @JIPrettyCool! Really appreciate it. Are there any other funny/weird translations that we should change?

I also approve the change in this translation. Other than that, there doesn't seem to be any issue.

However, as shown in the screenshot, for some reason, the widgets on the main screen appear in English.

Ekran Görüntüsü (141)

@nmfretz nmfretz changed the base branch from master to turkish-translation-fix-staging October 8, 2024 03:42
@nmfretz
Copy link
Collaborator

nmfretz commented Oct 8, 2024

Thanks again @JIPrettyCool and @mikropsoft! Really appreciate the contribution. Merging, and this will show up in the next umbrelOS release!

However, as shown in the screenshot, for some reason, the widgets on the main screen appear in English

Unfortunately, at this stage translations are not applied to widgets (or the app store). This is on our roadmap 🤝

@nmfretz nmfretz merged commit 1ea0f16 into getumbrel:turkish-translation-fix-staging Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants