-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code review #20
Code review #20
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Scott, this looks great! Happy to keep reviewing as you add more things. I would love to add a guide for statistical code review when the time is right.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, @sckott! Had a few comments mainly on the conventions section, obviously feel free to take or leave as you see fit. Thanks!
Co-authored-by: Monica Gerber <mwgerber@gmail.com>
Co-authored-by: Monica Gerber <mwgerber@gmail.com>
Co-authored-by: Monica Gerber <mwgerber@gmail.com>
sounds good @monicagerber |
Co-authored-by: Monica Gerber <mwgerber@gmail.com>
…ing, issues and Prs
See https://deploy-preview-20--monumental-cassata-2f9bb7.netlify.app/codereview
This isn't DONE. I'm hoping to get your feedback on what there is so far - the structure of the various chapters under code review, i left some notes in all caps or some alerts asking for feedback too