Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code review #20

Merged
merged 12 commits into from
Mar 14, 2024
Merged

Code review #20

merged 12 commits into from
Mar 14, 2024

Conversation

sckott
Copy link
Member

@sckott sckott commented Mar 1, 2024

See https://deploy-preview-20--monumental-cassata-2f9bb7.netlify.app/codereview

This isn't DONE. I'm hoping to get your feedback on what there is so far - the structure of the various chapters under code review, i left some notes in all caps or some alerts asking for feedback too

@github-actions github-actions bot temporarily deployed to pull request March 1, 2024 22:08 Inactive
@getwilds getwilds deleted a comment from github-actions bot Mar 1, 2024
@getwilds getwilds deleted a comment from github-actions bot Mar 1, 2024
Copy link
Contributor

@monicagerber monicagerber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Scott, this looks great! Happy to keep reviewing as you add more things. I would love to add a guide for statistical code review when the time is right.

codereview-dasl.qmd Show resolved Hide resolved
codereview-dasl.qmd Show resolved Hide resolved
codereview-guidelines.qmd Outdated Show resolved Hide resolved
codereview-guidelines.qmd Outdated Show resolved Hide resolved
codereview-guidelines.qmd Outdated Show resolved Hide resolved
codereview-guidelines.qmd Outdated Show resolved Hide resolved
codereview-guidelines.qmd Outdated Show resolved Hide resolved
codereview-guidelines.qmd Outdated Show resolved Hide resolved
Copy link
Member

@tefirman tefirman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, @sckott! Had a few comments mainly on the conventions section, obviously feel free to take or leave as you see fit. Thanks!

codereview-general.qmd Outdated Show resolved Hide resolved
conventions.qmd Outdated Show resolved Hide resolved
conventions.qmd Outdated Show resolved Hide resolved
conventions.qmd Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pull request March 5, 2024 21:34 Inactive
sckott and others added 2 commits March 5, 2024 13:45
Co-authored-by: Monica Gerber <mwgerber@gmail.com>
Co-authored-by: Monica Gerber <mwgerber@gmail.com>
@github-actions github-actions bot temporarily deployed to pull request March 5, 2024 21:48 Inactive
Co-authored-by: Monica Gerber <mwgerber@gmail.com>
@github-actions github-actions bot temporarily deployed to pull request March 5, 2024 21:50 Inactive
@getwilds getwilds deleted a comment from github-actions bot Mar 5, 2024
@getwilds getwilds deleted a comment from github-actions bot Mar 5, 2024
@getwilds getwilds deleted a comment from github-actions bot Mar 5, 2024
@sckott
Copy link
Member Author

sckott commented Mar 5, 2024

I would love to add a guide for statistical code review when the time is right.

sounds good @monicagerber

Co-authored-by: Monica Gerber <mwgerber@gmail.com>
@github-actions github-actions bot temporarily deployed to pull request March 8, 2024 00:26 Inactive
@github-actions github-actions bot temporarily deployed to pull request March 9, 2024 00:13 Inactive
Copy link

@github-actions github-actions bot temporarily deployed to pull request March 13, 2024 20:35 Inactive
@getwilds getwilds deleted a comment from github-actions bot Mar 14, 2024
@getwilds getwilds deleted a comment from github-actions bot Mar 14, 2024
@getwilds getwilds deleted a comment from github-actions bot Mar 14, 2024
@getwilds getwilds deleted a comment from github-actions bot Mar 14, 2024
Copy link

@github-actions github-actions bot temporarily deployed to pull request March 14, 2024 16:52 Inactive
@sckott sckott merged commit 689b53f into main Mar 14, 2024
1 check passed
Copy link

@github-actions github-actions bot temporarily deployed to pull request March 14, 2024 17:07 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants