Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release/3.8.0 #254

Merged
merged 9 commits into from
Jan 10, 2022
Merged

Release/3.8.0 #254

merged 9 commits into from
Jan 10, 2022

Conversation

LuborRod
Copy link
Contributor

@LuborRod LuborRod commented Jan 5, 2022

Changes

Added

  • Support for non-latin documents at session creation
  • Support for non-latin documents when fetching session configuration
  • Support for non-latin documents when fetching supported documents

Rodion Liuborets and others added 5 commits December 10, 2021 14:42
@LuborRod
SDK-1954 Add IbvOptions for session specigfication
091ed0f
@LuborRod
Sdk 1955 Add support for setting instructions for In-Branch Verificat…
9af307a 
…ion (#247)

* SDK-1955 Add main logic

* SDK-1955 Add tests
@LuborRod
SDK-2040 Support for non-latin documents at session creation and fix …
5e3710e 
…composer lint in github actions (#248)

Co-authored-by: Rodion Liuborets <rodion.liuborets@yoti.com>
@LuborRod
SDK-2041 Support for non-latin documents when fetching session config…
2c10869 
…uration (#249)

Co-authored-by: Rodion Liuborets <rodion.liuborets@yoti.com>
@LuborRod
SDK-2042 Add supporting for fetching supported documents (#250)
37957c3 
Co-authored-by: Rodion Liuborets <rodion.liuborets@yoti.com>
echarrod
echarrod reviewed Jan 5, 2022
View reviewed changes
Copy link
Contributor

@echarrod echarrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a function comment I noticed has been removed

src/DocScan/DocScanClient.php
@@ -129,13 +129,13 @@ public function deleteMediaContent(string $sessionId, string $mediaId): void
}

/**
* Gets a list of supported documents.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, presume this comment wasn't intentionally removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, I will add it. Thx.

@sonarcloud
Copy link

sonarcloud bot commented Jan 10, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

echarrod
echarrod approved these changes Jan 10, 2022
View reviewed changes
Copy link
Contributor

@echarrod echarrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@LuborRod LuborRod merged commit d0d5555 into master Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlmartyres jlmartyres jlmartyres approved these changes

@echarrod echarrod echarrod approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LuborRod @echarrod @jlmartyres