Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Session and Messages created and then immediately deleted have deleted state overwritten. #52

Closed
danielchalef opened this issue May 16, 2023 · 1 comment
Closed

Session and Messages created and then immediately deleted have deleted state overwritten. #52

danielchalef opened this issue May 16, 2023 · 1 comment

Comments

@danielchalef
Copy link
Member

Creating a session and messages and then immediately deleting them results in Extractors later, on completion, overwriting the DeletedAt state. This is because bun is using the DEFAULT value on inserts with on conflict update. See uptrace/bun#830

We should either wait to see if the bun team fixes this or implement a workaround.
danielchalef added a commit that referenced this issue May 18, 2023
@danielchalef
fix for #52. specify columns on insert/upsert to avoid overwriting de…
4300ad2 
…leted_at
danielchalef added a commit that referenced this issue May 18, 2023
@danielchalef
Fix for #52 (#58)
8668199 
* additonal debugging

* Revert "additonal debugging"

This reverts commit 52bb6a9.

* fix for #52. specify columns on insert/upsert to avoid overwriting deleted_at
@danielchalef
Copy link
Member Author

Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@danielchalef