Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify documentation with GH action deployment #1785

Closed
piedoom opened this issue Mar 2, 2022 · 1 comment
Closed

Simplify documentation with GH action deployment #1785

piedoom opened this issue Mar 2, 2022 · 1 comment

Comments

@piedoom
Copy link
Contributor

piedoom commented Mar 2, 2022

Documentation issue

Summary

It is unnecessary to create a personal access token when deploying to GH actions

Proposed solution

I recently learned that secrets.GITHUB_TOKEN is accessible, negating the need to create a personal access token, simplifying several steps + removing potential security issues that come with PATs.

This commit demonstrates my repository works when my previous secrets.TOKEN (which was manually set in secrets) is replaced by secrets.GITHUB_TOKEN, which is automatically set by actions. Fixing this documentation would necessitate removing a few sections regarding PATs.

@Keats
Copy link
Collaborator

Keats commented Mar 3, 2022

I believe PATs might only be needed now if you are publishing from a different repo, I'll have to double check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants