Docs/configuration update #1126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure splitting the content is a good idea. We went from something people can copy/paste to something else where you might not know exactly where it goes. |
- Attempt to split the configuration file into sections to make it more readable and avoid configuration mistakes (getzola#1056). - Move translation instructions to the right part. - Add a bit more explanations to the extra section.
uggla
force-pushed
the
docs/configuration_update
branch
from
70f0181
to
0ed1df1
Compare
uggla
force-pushed
the
docs/configuration_update
branch
from
3ea4417
to
7378893
Compare
uggla
commented
Aug 13, 2020
| # [translations.en] | ||
| # title = "A title" | ||
| # | ||
| # translated title value will be available using {{ config.get_translation("fr", "title") }} in templates |
There was a problem hiding this comment.
I'm not sure about this.
There was a problem hiding this comment.
Probably not needed, there should be a dedicated i18n page explaining how everything works.
There was a problem hiding this comment.
@Keats, ok I'm gonna remove it. I'll be happy to help about the i18n page, but right now I don't know how it works.
|
@Keats , I agree copy/paste is important. I have refined this PR according to your feedbacks. Let me know if it better suits what you expect ? |
- A i18n page should be created to better explain it.
|
Thanks! |
Keats
added a commit
that referenced
this pull request
Sep 1, 2020
* mention code block output change * Update snap * Update themes gallery (#1082) Co-authored-by: GitHub Action <action@github.com> * Deployment guide for Vercel * Change wording a bit * Update themes gallery (#1122) Co-authored-by: GitHub Action <action@github.com> * Add feed autodiscovery documentation (#1123) * Add feed autodiscovery documentation * Fix link in template * Docs/configuration update (#1126) * Update configuration documentation - Attempt to split the configuration file into sections to make it more readable and avoid configuration mistakes (#1056). - Move translation instructions to the right part. - Add a bit more explanations to the extra section. * Take into account @Keats feedbacks * Remove short notice about translation usage - A i18n page should be created to better explain it. * add fix for (#1135) Taxonomies with identical slugs now get merged (#1136) * add test and implementation for reverse pagination * incorporate review changes Co-authored-by: Michael Plotke <bdjnks@gmail.com> Co-authored-by: Vincent Prouillet <balthek@gmail.com> Co-authored-by: GitHub Action <action@github.com> Co-authored-by: Samyak Bakliwal <w3bcode@gmail.com> Co-authored-by: René Ribaud <uggla@free.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sanity check:
Explanation:
avoid configuration mistakes (Link checker sometimes flaky #1056).