Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support embed YouTube playlist #1342

Merged
merged 1 commit into from
Feb 7, 2021

Conversation

wdv4758h
Copy link
Contributor

@wdv4758h wdv4758h commented Feb 7, 2021

This is a tiny modification in shortcode. Let me know if it still need to go through discussion on forum.

This PR adds an extra paramter to YouTube shortcode for including playlist. One can easily use current id parameter to do the same thing, but it looks more like a hack. Adding a playlist parameter seems to be more clear.

To include playlist with youtube shortcode before PR (more like a hack):

{{ youtube(id="dQw4w9WgXcQ?list=RDdQw4w9WgXcQ") }}

After PR:

{{ youtube(id="dQw4w9WgXcQ", playlist="RDdQw4w9WgXcQ") }}

Sanity check:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Code changes

(Delete or ignore this section for documentation changes)

  • Are you doing the PR on the next branch?

If the change is a new feature or adding to/changing an existing one:

  • Have you created/updated the relevant documentation page(s)?

@Keats Keats merged commit 3cb61c3 into getzola:next Feb 7, 2021
@Keats
Copy link
Collaborator

Keats commented Feb 7, 2021

Thanks!

@wdv4758h wdv4758h deleted the shortcode/youtube-playlist branch February 7, 2021 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants