Fix theme images loading #2517
Merged
Fix theme images loading #2517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
berdandy
pushed a commit
to berdandy/azola
that referenced
this pull request
Sep 17, 2024
* chore: format themes file * feat: add aspect ratio to theme images
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sanity check:
The theme images currently have heights equal to one of the images with the other fitting via
object-fit: cover. This causes a lot of layout shift and inconsistent heights.To fix this, I just added an
aspect-ratio: 16 / 9as a progressive enhancement.Before
Testing with a slower connection to show layouts before the images load:
After
Testing with a slower connection to show layouts before the images load:
Additional Info
This project's docs site should probably try and find a formatter, as lots of the styles were inconsistent and formatting was most of the diff here. If the maintainer wishes to reduce the diff for this pull request, they may revert/drop the
chore: format themes filecommit.