Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an external link checker #337

Merged
merged 1 commit into from
Jul 17, 2018
Merged

Add an external link checker #337

merged 1 commit into from
Jul 17, 2018

Conversation

Keats
Copy link
Collaborator

@Keats Keats commented Jul 16, 2018

Close #115

@Keats
Copy link
Collaborator Author

Keats commented Jul 16, 2018

That seems to work, although there are some false negatives because of some sites behaving badly like crates.io (rust-lang/crates.io#788) which always return 404.
The workaround in the thread is to request html but I'm not going to go down the path of adding domain specific workarounds.

@Keats Keats merged commit ba8b696 into next Jul 17, 2018
@Keats Keats deleted the link-checker branch July 17, 2018 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant