Support png images #329
Merged
Support png images #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you so much for the enhancement! I confirmed that it indeed works as to output PDF files. A slight warning message was shown, however: $ cd tests/images/
$ satysfi test.saty
(omitted)
---- ---- ---- ----
evaluating texts ...
[Warning] (satysfi-logo-cmyk.jpg) Jpeg images with CMYK color mode are not fully supported.
Please convert the image to a jpeg image with YCbCr (RGB) color model.
[Warning] (peppers-cmyk.jpg) Jpeg images with CMYK color mode are not fully supported.
Please convert the image to a jpeg image with YCbCr (RGB) color model.
evaluation done.
---- ---- ---- ----
breaking contents into pages ...
needs another trial for solving cross references...
---- ---- ---- ----
evaluating texts (2nd trial) ...
[Warning] (satysfi-logo-cmyk.jpg) Jpeg images with CMYK color mode are not fully supported.
Please convert the image to a jpeg image with YCbCr (RGB) color model.
[Warning] (peppers-cmyk.jpg) Jpeg images with CMYK color mode are not fully supported.
Please convert the image to a jpeg image with YCbCr (RGB) color model.
evaluation done.
---- ---- ---- ----
breaking contents into pages ...
all cross references were solved.
---- ---- ---- ----
embedding fonts ...
libpng warning: Interlace handling should be turned on when using png_read_image
---- ---- ---- ----
writing pages ...
---- ---- ---- ----
output written on 'test.pdf'.Is the occurrence of the message |
|
Ah, I noticed this message. It is emitted only for interlaced images (in this case, basi0g01.png). If we use only non-interlaced pngs, we do not see this message. I think this behavior is not so harmful. |
|
Thank you for explanation. I understand. I will merge this PR. Again, thank you so much for the development! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds PNG images support. Supported PNG formats are monochrome, grayscale, rgb, and 4/8 bit colormap (1/2 bit colormap and alpha-channel are not supported).
Supported formats are summarized as below (full lists can be built from
tests/images/test.saty):