Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more shell escaping when passing args #38

Merged
merged 1 commit into from
Dec 17, 2015
Merged

Conversation

gfontenot
Copy link
Owner

Previously we were just passing the project, workspace, and scheme to
the command line completely unescaped. This isn't super safe. Instead,
we should pass all of these through our cli_args function to add
quotes and a leading space for everything that's passed to the command
line.

Fixes #27

Hat tip to @stack for the original implementation in
#34

Previously we were just passing the project, workspace, and scheme to
the command line completely unescaped. This isn't super safe. Instead,
we should pass all of these through our `cli_args` function to add
quotes and a leading space for everything that's passed to the command
line.

Hat tip to #34 for the
original implementation.
@gfontenot gfontenot merged commit e9eeb9d into master Dec 17, 2015
@gfontenot gfontenot deleted the gf-shell-escaping branch December 17, 2015 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant