Issue/edgecases #20
Merged
Issue/edgecases #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The first config value written to file was ending up on the same line as `[settings]` so was ignored by isort.
- Indenting was incorrect. - Update wording. - Change return to break as object is modified in-place.
- With an empty file in_lines and out_lines don't match so if list has a single empty string entry skip newlines changes.
cas--
force-pushed
the
Issue/Edgecases
branch
from
9968211
to
7790991
Compare
|
@cas-- thanks!! 👍 if I had not released the version you wouldn't probably notice that error, so all is fine :-) we can make as much releases as needed anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As is always the case, you make a release then find a few more bugs ;)
These commits fix:
[settings]and therefore ignored.