Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add universal wheel support #33

Merged
merged 1 commit into from
May 7, 2017
Merged

Add universal wheel support #33

merged 1 commit into from
May 7, 2017

Conversation

jdufresne
Copy link
Contributor

As flake8-isort is a pure Python package, it is safe to distribute using universal wheels.

From http://pythonwheels.com/

Advantages of wheels

  • Faster installation for pure python packages.
  • Avoids arbitrary code execution for installation. (Avoids setup.py)
  • Allows better caching for testing and continuous integration.
  • Creates .pyc files as part of installation to ensure they match the python interpreter used.
  • More consistent installs across platforms and machines.

When you'd normally run python setup.py sdist upload, run instead python setup.py sdist bdist_wheel upload

Wheel documentation:

https://wheel.readthedocs.io/en/latest/

PEP 427 -- The Wheel Binary Package Format 1.0:

https://www.python.org/dev/peps/pep-0427/

As flake8-isort is a pure Python package, it is safe to distribute using
universal wheels.

From http://pythonwheels.com/

> Advantages of wheels
>
> * Faster installation for pure python packages.
> * Avoids arbitrary code execution for installation. (Avoids setup.py)
> * Allows better caching for testing and continuous integration.
> * Creates .pyc files as part of installation to ensure they match the
>   python interpreter used.
> * More consistent installs across platforms and machines.

When you'd normally run `python setup.py sdist upload`, run instead
`python setup.py sdist bdist_wheel upload`

Wheel documentation:

https://wheel.readthedocs.io/en/latest/

PEP 427 -- The Wheel Binary Package Format 1.0:

https://www.python.org/dev/peps/pep-0427/
@jdufresne jdufresne closed this May 7, 2017
@jdufresne jdufresne reopened this May 7, 2017
@coveralls
Copy link

coveralls commented May 7, 2017

Coverage Status

Coverage remained the same at 89.691% when pulling 3f64c1c on jdufresne:wheel into c15fc73 on gforcada:master.

@gforcada
Copy link
Owner

gforcada commented May 7, 2017

@jdufresne Thanks! I usually use zest.releaser (you should try it!).

@gforcada gforcada merged commit a83caa8 into gforcada:master May 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants