Use pip-tools to constrain CI requirements #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In .travis.yml, the versions of coveralls and pytest-cov were unconstrained, creating a risk of failure in Travis CI builds if an incompatible version of pytest-cov or coveralls is released. As suggested in gforcada#89, use pip-tools to address this risk. The dependencies for coverage testing are in requirements-cov.in. The frozen set of packages is in requirements-cov.txt, compiled for python 2.7. This is only for coverage testing, since pip-tools doesn't handle relative paths and a minimal environment can help detect undeclared dependencies.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
.travis.yml, the versions ofcoverallsandpytest-covwere unconstrained, creating a risk of failure in Travis CI builds if an incompatible version ofpytest-covorcoverallsis released.As suggested in #89, use
pip-toolsto address this risk. The dependencies for coverage testing are inrequirements-cov.in. The frozen set of packages is inrequirements-cov.txt, compiled forpython 2.7.
This is only for coverage testing, since
pip-toolsdoesn't handle relative paths and a minimal environment can help detect undeclared dependencies.