Define call not removed

[GianlucaGuarini]

Hi I am trying to clean a project that uses Backbone.layoutManager but amdclean does not remove all the define calls. Am I doing something wrong?

http://gregfranko.com/amdclean/?code=(function(window%2C%20factory)%20%7B%0A%20%20%22use%20strict%22%3B%0A%20%20var%20Backbone%20%3D%20window.Backbone%3B%0A%0A%20%20%2F%2F%20AMD.%20Register%20as%20an%20anonymous%20module.%20%20Wrap%20in%20function%20so%20we%20have%20access%0A%20%20%2F%2F%20to%20root%20via%20%60this%60.%0A%20%20if%20(typeof%20define%20%3D%3D%3D%20%22function%22%20%26%26%20define.amd)%20%7B%0A%20%20%20%20return%20define(%5B%22backbone%22%2C%20%22underscore%22%2C%20%22jquery%22%5D%2C%20function()%20%7B%0A%20%20%20%20%20%20return%20factory.apply(window%2C%20arguments)%3B%0A%20%20%20%20%7D)%3B%0A%20%20%7D%0A%0A%20%20%2F%2F%20Browser%20globals.%0A%20%20Backbone.Layout%20%3D%20factory.call(window%2C%20Backbone%2C%20window._%2C%20Backbone.%24)%3B%0A%7D(typeof%20global%20%3D%3D%3D%20%22object%22%20%3F%20global%20%3A%20this%2C%20function%20(Backbone%2C%20_%2C%20%24)%20%7B%0A%20%20%22use%20strict%22%3B%0A%7D))

[GianlucaGuarini]

I am sorry but it looks like amdclean does not clean all the define calls like it should. I have created a branch on my project just to find out how to build it using amdclean maybe you could help me out.
https://github.com/time2/web-app/tree/amdclean

[gfranko]

I just locally cloned your repo and tried to run your grunt task, but it is complaining because you don't have a vendors folder and you specified that folder in your Require.js configuration. Let me know when your Grunt task is fixed and then I will take another look.

[GianlucaGuarini]

just run

$ sudo npm install bower -g && bower install

[gfranko]

ahhh, looking again

[gfranko]

I just created an issue on the Backbone.layoutManager repo, complaining about the way they are doing their conditional AMD support.

Until they fix that, if you update the Backbone.layoutManager source code to not return their conditional define() method call, everything should work. In the mean time, I will look for a better long-term solution for AMDclean to handle situations like this. I'll let you know when I have one.

[GianlucaGuarini]

Thank you so much, now that I know where is the problem I could create a temporary workaround 🔨

[gfranko]

No problem. I need to find a permanent solution for problems like this.

[GianlucaGuarini]

After one day spent building my project with amdclean without any success ( I have tried everything... also the fix discussed above ) I have to give up 🚶 there is no way to use amdclean on complex projects with many dependencies and libraries, It's supposed to work out of the box right like almond.js but it does not unfortunately. I will keep the branch up just in case someone would like to try building a working dist folder https://github.com/time2/time2.github.io/tree/amdclean

[gfranko]

I just released AMDclean 2.2.0, which should clear up all of your issues. Please re-test.

With this release, I am very confident in saying that AMDclean can handle anything you throw at it.

[GianlucaGuarini]

Thank you @gfranko looking forward to testing it.. I will let you know soon

[gfranko]

Sounds good, lemme know if you run into any issues!

[GianlucaGuarini]

well done! It works perfectly thank you so much 👍