Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] Missing heartbeat should trigger an I/O failure #125

Closed
rtxm opened this issue Apr 9, 2024 · 4 comments · Fixed by #126
Closed

[feature request] Missing heartbeat should trigger an I/O failure #125

rtxm opened this issue Apr 9, 2024 · 4 comments · Fixed by #126
Assignees

Comments

@rtxm
Copy link

rtxm commented Apr 9, 2024

If the link is dropped between the client and the broker (router failure, VPN disconnect, etc…), the TCP connection remains open (Established) but nothing pass through. The heartbeat is meant to detect that condition, and we'd like to reset the connection on the client side, as the broker do on its own side of the link.

@gftea
Copy link
Owner

gftea commented Apr 15, 2024

Hi, indeed we can add it.
Is TCP keepalives enabled on your machine?

@rtxm
Copy link
Author

rtxm commented Apr 16, 2024

TCP keepalive is system wide and would impact all services, whereas we can set the AMQP heartbeat per application (per connection actually!) depending on requirements.

@gftea
Copy link
Owner

gftea commented Apr 18, 2024

@rtxm , please check the pr #126 if working for your use cases

@rtxm
Copy link
Author

rtxm commented Apr 19, 2024

It does! Thanks!

@gftea gftea self-assigned this Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants