-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fieldarray deserialization fail #64
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stead of number of elements in the array
gftea
reviewed
Feb 27, 2023
gftea
reviewed
Feb 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks very much for your PR!
Codecov Report
@@ Coverage Diff @@
## main #64 +/- ##
==========================================
- Coverage 85.33% 85.12% -0.21%
==========================================
Files 42 42
Lines 5850 5931 +81
==========================================
+ Hits 4992 5049 +57
- Misses 858 882 +24
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
gftea
reviewed
Feb 27, 2023
jdelgadoalfonso
commented
Mar 1, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fieldarray deserialization fail because of length counts bytes instead of number of elements in the array.
Making an app which consumes from a queue that is bind to the RabbitMQ event exchange plugin, I faced up with a panic deserializing the header.
There is a client_properties field of type FieldArray. RabbitMQ is filling the length with the number of bytes instead of the number of elements of the given array