Go to next input when in the root of the list #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When rotating over the list of inputs, you traverse the root of the list. This is an empty node, so you need to advance to the next element.
Closed
SourceDoctor
added a commit
to SourceDoctor/mptsd
that referenced
this pull request
Sep 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When rotating over the list of inputs, you traverse the root of the list. This is an empty node, so you need to advance to the next element.
So, without this code a SEVERE bug exists inside the muxing task: Every time you go over the root of the list, then a NULL padding packet is inserted in the output. This consumes around 1/N of the bandwith (where N is the number of inputs). This patch fixes the bug and no padding is inserted when data is in the input buffer.