-
Notifications
You must be signed in to change notification settings - Fork 547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies & examples to glutin 0.9 / winit 0.7 #1362
Conversation
Updated the description so that #1348 will auto-close. |
I've amended the commit to fix Vulkan compile issue, and apply the same fixes to mac/windows. I couldn't actually test these though. |
Updated & tested OpenGL examples Update other backends Incremented winit depending backends by x.x.1 Incremented winit/glutin depending windows by x.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work, thank you!
Just one question/concern before we proceed.
} | ||
}, | ||
_ => app.on(event), | ||
events_loop.poll_events(|event| { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any reason the poll_events
blocks are rewritten? is it rustfmt
doing the work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code had to be reworked to handle the winit::Event
rework. Events seem to be split into Device & Window now, plus in general all winit events are more nested and have switched to named variable enums.
I've simply reworked the existing code into the new structure.
@alexheretic you might have already addressed this somewhere else, but I couldn't find it in this PR so just in case I wanted to add that Originally this was not necessary as glutin wrapped the entire |
Thanks @mitchmindtree, nice spot. Not ideal from a consumers perspective. I'll raise a PR to fix the examples. |
This PR brings gfx up to date with the latest glutin & winit releases. Having a
ContextBuilder
in addition to theWindowBuilder
and a rework of the event structures are the main changes for gfx users. The events are particularly groansome for refactoring. I'm particularly interested in getting gfx up to date so I can finally have XWayland window support in Linux. See glutin ContextBuilder addition PR & winit event rework PRFixes #1348