Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement DRAW_INDIRECT_COUNT features #3281

Merged
merged 1 commit into from
Aug 15, 2020

Conversation

cwfitzgerald
Copy link
Member

Forward-ports #3279 to master. The default impl in the hal was removed in favor of stub impls in all the backends. Addtionally the mesh shader function machinery was combined with the machinery #3279 adds to get extension pointers.

Copy link

@monocodus monocodus bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an autogenerated code review, new suggestions: 17

src/backend/dx12/src/command.rs Show resolved Hide resolved
src/backend/dx12/src/command.rs Show resolved Hide resolved
src/backend/empty/src/lib.rs Outdated Show resolved Hide resolved
src/backend/empty/src/lib.rs Outdated Show resolved Hide resolved
src/backend/gl/src/command.rs Show resolved Hide resolved
src/backend/vulkan/src/command.rs Show resolved Hide resolved
src/backend/vulkan/src/command.rs Show resolved Hide resolved
src/backend/vulkan/src/command.rs Show resolved Hide resolved
src/backend/webgpu/src/command.rs Show resolved Hide resolved
src/backend/webgpu/src/command.rs Show resolved Hide resolved
@kvark
Copy link
Member

kvark commented Jun 28, 2020

Thank you!
CI is mad, otherwise good to go :)

@kvark
Copy link
Member

kvark commented Aug 15, 2020

bors r+

@bors
Copy link
Contributor

bors bot commented Aug 15, 2020

Build succeeded:

@bors bors bot merged commit 12d641c into gfx-rs:master Aug 15, 2020
@cwfitzgerald cwfitzgerald deleted the indirect-count-master branch October 20, 2020 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants