Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all the Borrows #3586

Merged
merged 10 commits into from
Jan 19, 2021
Merged

Remove all the Borrows #3586

merged 10 commits into from
Jan 19, 2021

Conversation

kvark
Copy link
Member

@kvark kvark commented Jan 13, 2021

Fixes #3569
PR checklist:

  • make succeeds (on *nix)
  • make reftests succeeds

Tested with:

@kvark kvark requested a review from grovesNL January 13, 2021 15:31
@kvark kvark marked this pull request as draft January 13, 2021 15:46
@kvark kvark changed the title Remove Borrow of Barrier Remove all the Borrows Jan 16, 2021
@kvark kvark force-pushed the borrow branch 3 times, most recently from cc24709 to 2533d17 Compare January 18, 2021 06:50
@kvark kvark marked this pull request as ready for review January 18, 2021 06:59
@kvark
Copy link
Member Author

kvark commented Jan 19, 2021

bors r=grovesNL

@bors
Copy link
Contributor

bors bot commented Jan 19, 2021

@bors bors bot merged commit e337688 into gfx-rs:master Jan 19, 2021
@kvark kvark deleted the borrow branch January 19, 2021 04:50
bors bot added a commit to gfx-rs/portability that referenced this pull request Jan 19, 2021
240: Update to gfx-hal borrow refactor r=kvark a=kvark

Depends on gfx-rs/gfx#3586
Also:
  - removes typed-arena dependency
  - removes soundness bug with semaphore fake state
  - use `make_slice` more

Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
bors bot added a commit to gfx-rs/wgpu that referenced this pull request Jan 19, 2021
1156: Update gfx to unborrowed APIs r=kvark a=kvark

**Connections**
Depends on gfx-rs/gfx#3586
Depends on zakarumych/gpu-descriptor#10

**Description**
Just an update.

**Testing**
Tested on wgpu-rs examples.

Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't use Borrow with lifetimes in the API
2 participants