Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wgsl-in] Fail if the @workgroup_size attribute is repeated #2434

Closed
fornwall opened this issue Aug 13, 2023 · 1 comment · Fixed by #2435
Closed

[wgsl-in] Fail if the @workgroup_size attribute is repeated #2434

fornwall opened this issue Aug 13, 2023 · 1 comment · Fixed by #2435

Comments

@fornwall
Copy link
Contributor

Follow up work on #2428:

Validate that the @workgroup_size attribute is not repeated, just as #2428 validates other attributes.

This will probably fix #2271, Bad error message for compute entry point without @workgroup_size attribute, as a side effect.
@fornwall
Copy link
Contributor Author

I plan to do this as soon as #2428 has landed.

@fornwall fornwall mentioned this issue Aug 13, 2023
Merged
fornwall added a commit to fornwall/naga that referenced this issue Aug 13, 2023
@fornwall
[wgsl-in] Handle repeated or missing @workgroup_size
98dd99c 
Fixes gfx-rs#2271 and gfx-rs#2434.
@fornwall fornwall mentioned this issue Aug 13, 2023
Merged
fornwall added a commit to fornwall/naga that referenced this issue Aug 13, 2023
@fornwall
[wgsl-in] Handle repeated or missing @workgroup_size
b9e36bf 
Fixes gfx-rs#2271 and gfx-rs#2434.
@fornwall fornwall changed the title [wgsl-in] Fail if the @workgroup_size attribute is repated [wgsl-in] Fail if the @workgroup_size attribute is repeated Aug 13, 2023
fornwall added a commit to fornwall/naga that referenced this issue Aug 14, 2023
@fornwall
[wgsl-in] Handle repeated or missing @workgroup_size
52b2f7c 
Fixes gfx-rs#2271 and gfx-rs#2434.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[wgsl-in] Handle repeated or missing @workgroup_size fornwall/naga
1 participant
@fornwall