Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hlsl-out] Texture functions implementation #1086

Merged
merged 4 commits into from
Jul 16, 2021
Merged

Conversation

Gordon-F
Copy link
Collaborator

No description provided.

src/back/hlsl/writer.rs Outdated Show resolved Hide resolved
src/back/hlsl/writer.rs Outdated Show resolved Hide resolved
src/back/hlsl/writer.rs Outdated Show resolved Hide resolved
src/back/hlsl/writer.rs Outdated Show resolved Hide resolved
src/back/hlsl/writer.rs Outdated Show resolved Hide resolved
src/back/hlsl/writer.rs Outdated Show resolved Hide resolved
src/back/hlsl/writer.rs Outdated Show resolved Hide resolved
src/back/hlsl/writer.rs Outdated Show resolved Hide resolved
src/back/hlsl/writer.rs Outdated Show resolved Hide resolved
src/back/hlsl/writer.rs Outdated Show resolved Hide resolved
src/back/hlsl/writer.rs Outdated Show resolved Hide resolved
src/back/hlsl/writer.rs Show resolved Hide resolved
src/back/hlsl/writer.rs Show resolved Hide resolved
src/back/hlsl/writer.rs Outdated Show resolved Hide resolved
bors bot added a commit to gfx-rs/wgpu that referenced this pull request Jul 15, 2021
1664: hal/dx12: reset scissor and viewport r=kvark a=kvark

**Connections**
Follow-up to #1602 that actually makes it render!

**Description**
"hello-triange" and "msaa-line" examples work now.
Everything else is blocked on Naga's HLSL output, starting from gfx-rs/naga#1086

**Testing**
Ran the examples :)


Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
@Gordon-F Gordon-F marked this pull request as ready for review July 15, 2021 21:11
@Gordon-F Gordon-F requested a review from kvark July 15, 2021 21:19
Copy link
Member

@kvark kvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last few fixes are needed. Great work overall!

src/back/hlsl/writer.rs Outdated Show resolved Hide resolved
src/back/hlsl/writer.rs Outdated Show resolved Hide resolved
src/back/hlsl/writer.rs Outdated Show resolved Hide resolved
src/back/mod.rs Outdated Show resolved Hide resolved
src/back/mod.rs Outdated Show resolved Hide resolved
@kvark kvark merged commit 4ef754b into gfx-rs:master Jul 16, 2021
@Gordon-F Gordon-F deleted the hlsl-out branch July 16, 2021 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants