Fix release regex #212
Merged
Fix release regex #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarijnS95
reviewed
Aug 16, 2021
rspirv/Cargo.toml
Outdated
| [dependencies.spirv] | ||
| version = "=0.1" | ||
| path = "../spirv" | ||
| spirv = { version = "=0.1.0+1.5.4", path = "../spirv" } |
There was a problem hiding this comment.
A dependency shouldn't use the +metadata bit though, I hope cargo-release understands and strips that off?
There was a problem hiding this comment.
It ouput's like this which seems to make sense: Fixing rspirv's dependency on spirv to '= 0.1.1' (from '= 0.1.0')"
There was a problem hiding this comment.
@Jasper-Bekkers Does that mean it's already bumping the version to 0.1.1 before releasing? We should teach cargo-release that 0.1.0 is our first release that isn't actually out yet. Maybe we should set it to 0.0.0 and pass 0.1.0 or 1.0.0 as argument to cargo-release instead?
There was a problem hiding this comment.
Good point! :-)
MarijnS95
reviewed
Aug 16, 2021
Jasper-Bekkers
force-pushed
the
update-release-regex
branch
from
59a80ff
to
dc28502
Compare
MarijnS95
approved these changes
Aug 16, 2021
Jasper-Bekkers
force-pushed
the
update-release-regex
branch
from
149ff97
to
295d870
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.