Simplify extensions. Add Debug PrintF #216
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matthias-Fauconneau
force-pushed
the
ext
branch
2 times, most recently
from
4cf0c17
to
ad4bf42
Compare
MarijnS95
reviewed
Sep 23, 2021
Comment on lines
+66
to
+76
| let mut original = | ||
| serde_json::from_str( | ||
| &std::str::from_utf8( | ||
| &fs::read(autogen_src_dir.join( | ||
| "external/SPIRV-Headers/include/spirv/unified1/spirv.core.grammar.json", | ||
| )) | ||
| .unwrap(), | ||
| ) | ||
| .unwrap(), | ||
| ) | ||
| .unwrap(); |
There was a problem hiding this comment.
Suggested change
| let mut original = | |
| serde_json::from_str( | |
| &std::str::from_utf8( | |
| &fs::read(autogen_src_dir.join( | |
| "external/SPIRV-Headers/include/spirv/unified1/spirv.core.grammar.json", | |
| )) | |
| .unwrap(), | |
| ) | |
| .unwrap(), | |
| ) | |
| .unwrap(); | |
| let mut original = serde_json::from_str( | |
| &fs::read_to_string( | |
| autogen_src_dir | |
| .join("external/SPIRV-Headers/include/spirv/unified1/spirv.core.grammar.json"), | |
| ) | |
| .unwrap(), | |
| ) | |
| .unwrap(); |
Maybe keep this simple with read_to_string? Same below.
There was a problem hiding this comment.
Yes! I didn't know about it ><.
There really should be a note in std:fs::read about read_to_string existence. It's not the first time this annoys me ^^
MarijnS95
reviewed
Sep 23, 2021
Comment on lines
+82
to
+84
| ("GLSL.std.450", "GLOp", "https://www.khronos.org/registry/spir-v/specs/unified1/GLSL.std.450.html"), | ||
| ("OpenCL.std.100", "CLOp", "https://www.khronos.org/registry/spir-v/specs/unified1/OpenCL.ExtendedInstructionSet.100.html"), | ||
| ("NonSemantic.DebugPrintF", "DebugPrintFOp", "https://github.com/KhronosGroup/Vulkan-ValidationLayers/blob/master/docs/debug_printf.md"), |
There was a problem hiding this comment.
Please use spaces to indent this. The autoformatter refuses to do so because the lines are too long.
Suggested change
| ("GLSL.std.450", "GLOp", "https://www.khronos.org/registry/spir-v/specs/unified1/GLSL.std.450.html"), | |
| ("OpenCL.std.100", "CLOp", "https://www.khronos.org/registry/spir-v/specs/unified1/OpenCL.ExtendedInstructionSet.100.html"), | |
| ("NonSemantic.DebugPrintF", "DebugPrintFOp", "https://github.com/KhronosGroup/Vulkan-ValidationLayers/blob/master/docs/debug_printf.md"), | |
| ("GLSL.std.450", "GLOp", "https://www.khronos.org/registry/spir-v/specs/unified1/GLSL.std.450.html"), | |
| ("OpenCL.std.100", "CLOp", "https://www.khronos.org/registry/spir-v/specs/unified1/OpenCL.ExtendedInstructionSet.100.html"), | |
| ("NonSemantic.DebugPrintF", "DebugPrintFOp", "https://github.com/KhronosGroup/Vulkan-ValidationLayers/blob/master/docs/debug_printf.md"), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.