Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WGSL: xyzw and rgba are not allowed to apear in same swizzle #6184

Closed
sagudev opened this issue Aug 30, 2024 · 0 comments · Fixed by #6187
Closed

WGSL: xyzw and rgba are not allowed to apear in same swizzle #6184

sagudev opened this issue Aug 30, 2024 · 0 comments · Fixed by #6187
Labels
area: naga front-end lang: WGSL WebGPU Shading Language naga Shader Translator type: bug Something isn't working

Comments

@sagudev
Copy link
Contributor

sagudev commented Aug 30, 2024 •
edited
Loading

const r = vec4(0.0, 0.0, 0.0, 0.0).xg; should return validation error: https://www.w3.org/TR/WGSL/#vector-multi-component

relevant code where we ignore this error:

wgpu/naga/src/front/wgsl/lower/mod.rs

Line 874 in 34bb9e4

const fn letter_component(letter: char) -> Option<crate::SwizzleComponent> {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: naga front-end lang: WGSL WebGPU Shading Language naga Shader Translator type: bug Something isn't working
Projects
WebGPU for Firefox
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[naga wgsl] all swizzle components must be either color or dimension sagudev/wgpu
2 participants
@sagudev @teoxoy